fix: Hung up on slow rendering arts #9899
Conversation
hassnian
requested review from
preschian and
Jarsen136
and removed request for
a team
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -18,6 +18,7 @@ export type MassMintNFT = Omit<ToMintNft, 'priceUSD'> & { | |||
| hash: string | |||
| sn?: number | |||
| entropyRange: EntropyRange | |||
| canRender: boolean | |||
There was a problem hiding this comment.
Is there any simpler way than this?
Is it possible to render a static image if multiple amounts? Else, render canvas
There was a problem hiding this comment.
hmmm , correct me if I'm wrong , but as far I know we need to render the canvas at least once to be able to upload the metadata.
we don't have access to any static image of that nft variation, unless we have them pre-generated. (iirc that was mentioned as a possibility to speed up our minting process )
There was a problem hiding this comment.
hmmm , correct me if I'm wrong , but as far I know we need to render the canvas at least once to be able to upload the metadata.
aahh, I see 👍🏻
let me re-check
There was a problem hiding this comment.
We can get base64 static image from toMintNft.imageDataPayload?.image. Could you check if it is still laggy if we load multiple base64 images?
There was a problem hiding this comment.
added cb48a04
the break
after 2-3 canvas i does hang up for a couple of secs
i'm running a m1 pro ( better than the average user's computer (I would assume)) and I see my CPU usage going crazy
I can image some user's browser just crashing/ not responding , , lowering the max will make for slower minting process , not sure how do we improve this
overall
I do see a difference , it's hard to see on these videos
30 nfts
canary
even though they rendered faster (no max amount) it's kinda laggy and I see some nfts going blank (there is memory cap or something?)
CleanShot.2024-03-28.at.14.29.06.mp4
this pr
renders slower ,(max of 3 at once) but after that its pretty smooth.
CleanShot.2024-03-28.at.14.28.28.mp4
There was a problem hiding this comment.
renders slower ,(max of 3 at once) but after that its pretty smooth.
nice, is it still faster if we remove "max of 3" stuff?
There was a problem hiding this comment.
would be nice if we can get rid of isRendering stuff
|
|
Code Climate has analyzed commit cb48a04 and detected 0 issues on this pull request. View more on Code Climate. |
|
first got hooked like over minute on this one
but second attempt went ok! maybe parallel after render upload it to IPFS as well? can be done on separate, this is already huge improvement if someone want to mint 5-10 pcs right away |
yangwao
added
the
S-works-for-me-✅
|
lwf |
|
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
PR Type
Context
added a max of 3 at once
Needs QA check
Did your issue had any of the "$" label on it?
Screenshot 📸