Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate variants on fails base64 image #9597

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

preschian
Copy link
Member

@preschian preschian commented Feb 29, 2024

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 7c0d3cb
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65e0c80a8091c300081efb29
😎 Deploy Preview https://deploy-preview-9597--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@preschian preschian marked this pull request as ready for review February 29, 2024 18:06
@preschian preschian requested a review from a team as a code owner February 29, 2024 18:06
@preschian preschian requested review from Jarsen136 and prury and removed request for a team February 29, 2024 18:06
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codeclimate bot commented Feb 29, 2024

Code Climate has analyzed commit 7c0d3cb and detected 0 issues on this pull request.

View more on Code Climate.

@prury
Copy link
Member

prury commented Feb 29, 2024

appeared only once, then i cleared cache and it no longer showed, i hope its fixed, ty @preschian
@yangwao please include this in release

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Feb 29, 2024
@yangwao
Copy link
Member

yangwao commented Feb 29, 2024

seems it was worth to wait

@yangwao
Copy link
Member

yangwao commented Feb 29, 2024

Thanks!
pay 30 usd

@yangwao yangwao merged commit 78a56af into main Feb 29, 2024
19 checks passed
@yangwao yangwao deleted the fix-generate-variants branch February 29, 2024 19:04
This was referenced Feb 29, 2024
@daiagi daiagi mentioned this pull request Mar 7, 2024
4 tasks
This was referenced Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants