Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick fix: ensure drop loading state can be cleared #9586

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

newraina
Copy link
Member

@newraina newraina commented Feb 29, 2024

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

The reason for the issue is: In the sketch code of old drop, kodahash/render/completed event might not exist.

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

@newraina newraina requested a review from a team as a code owner February 29, 2024 02:38
@newraina newraina requested review from preschian and Jarsen136 and removed request for a team February 29, 2024 02:38
@kodabot
Copy link
Collaborator

kodabot commented Feb 29, 2024

SUCCESS @newraina PR for issue #9585 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3c53592
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65e0bb77dcd4170008da6272
😎 Deploy Preview https://deploy-preview-9586--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Feb 29, 2024

Code Climate has analyzed commit 3c53592 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.7% Duplication on New Code

See analysis details on SonarCloud

@yangwao
Copy link
Member

yangwao commented Feb 29, 2024

@prury good to go?

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Feb 29, 2024
@prury
Copy link
Member

prury commented Feb 29, 2024

@prury good to go?

yup

@yangwao
Copy link
Member

yangwao commented Feb 29, 2024

Thanks!
pay 30 usd

@yangwao yangwao merged commit 2263126 into kodadot:main Feb 29, 2024
18 of 19 checks passed
@yangwao
Copy link
Member

yangwao commented Feb 29, 2024

😍 Perfect, I’ve sent the payout
💵 $30 @ 8.46 USD/DOT ~ 3.546 $DOT
🧗 1CAv6Zq3yVxL3eKhC94GWTWVwp1w4jZbqeZ6wXx1rPAhrce
🔗 0xb8cc711595b89dcf88918c70800f4f6db73b11e018002005cfa1c00576b61538

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 29, 2024
This was referenced Feb 29, 2024
@newraina newraina deleted the 9585 branch February 29, 2024 23:27
This was referenced Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

button on the old drop is always loading
6 participants