Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

farcaster icon light mode #9584

Merged
merged 2 commits into from
Feb 29, 2024
Merged

farcaster icon light mode #9584

merged 2 commits into from
Feb 29, 2024

Conversation

iMac7
Copy link
Contributor

@iMac7 iMac7 commented Feb 29, 2024

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screenshot_20240229_051638
    Screenshot_20240229_051731

@iMac7 iMac7 requested a review from a team as a code owner February 29, 2024 02:18
@iMac7 iMac7 requested review from preschian and Jarsen136 and removed request for a team February 29, 2024 02:18
@kodabot
Copy link
Collaborator

kodabot commented Feb 29, 2024

SUCCESS @iMac7 PR for issue #9582 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 7117b94
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65e01f27c8bc6a0008dbbb14
😎 Deploy Preview https://deploy-preview-9584--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@exezbcz
Copy link
Member

exezbcz commented Feb 29, 2024

could you please reorder it so its next to twitter

Copy link

codeclimate bot commented Feb 29, 2024

Code Climate has analyzed commit 7117b94 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@iMac7
Copy link
Contributor Author

iMac7 commented Feb 29, 2024

could you please reorder it so its next to twitter

done

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Feb 29, 2024
@yangwao
Copy link
Member

yangwao commented Feb 29, 2024

pay 20 usd
Thanks!

@yangwao yangwao merged commit 44e7cb8 into kodadot:main Feb 29, 2024
18 of 19 checks passed
This was referenced Feb 29, 2024
@iMac7
Copy link
Contributor Author

iMac7 commented Mar 3, 2024

@yangwao failed payout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

farcaster icon at light mode
7 participants