Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable RMRK1/2 Minting #9573

Merged
merged 10 commits into from
Feb 28, 2024
Merged

Disable RMRK1/2 Minting #9573

merged 10 commits into from
Feb 28, 2024

Conversation

prury
Copy link
Member

@prury prury commented Feb 27, 2024 •
edited
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

maybe not the best solution, let me know

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

image

image

@netlify Netlify
Copy link

netlify bot commented Feb 27, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit efa3a51
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65df88dd9df8790007e3cdb4
😎 Deploy Preview https://deploy-preview-9573--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury prury marked this pull request as ready for review February 27, 2024 22:21
@prury prury requested a review from a team as a code owner February 27, 2024 22:21
@prury prury requested review from preschian and Jarsen136 and removed request for a team February 27, 2024 22:21
Jarsen136
Jarsen136 reviewed Feb 28, 2024
View reviewed changes
components/massmint/Massmint.vue Outdated Show resolved Hide resolved
components/create/CreateNft.vue Outdated Show resolved Hide resolved
components/create/CreateNft.vue Outdated Show resolved Hide resolved
@prury prury marked this pull request as draft February 28, 2024 14:49
@exezbcz
Copy link
Member

exezbcz commented Feb 28, 2024

looks good to me, thanks for considering the warning if users lands with rmrk/2 selected

@prury prury marked this pull request as ready for review February 28, 2024 17:11
Jarsen136
Jarsen136 reviewed Feb 28, 2024
View reviewed changes
components/create/CreateNft.vue Outdated Show resolved Hide resolved
components/create/CreateNft.vue Outdated Show resolved Hide resolved
components/create/CreateNft.vue Outdated Show resolved Hide resolved
@prury @Jarsen136
code review 2
efa3a51 
Co-authored-by: Jarsen <[email protected]>
@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 28, 2024

Code Climate has analyzed commit efa3a51 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury
Copy link
Member Author

prury commented Feb 28, 2024

@Jarsen136 ty, done

Jarsen136
Jarsen136 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@yangwao
Copy link
Member

yangwao commented Feb 28, 2024

Thanks!
pay 30 usd

@yangwao yangwao merged commit 051bbc8 into main Feb 28, 2024
19 checks passed
@yangwao yangwao deleted the disable-kusama-minting branch February 28, 2024 22:58
@yangwao
Copy link
Member

yangwao commented Feb 28, 2024

😍 Perfect, I’ve sent the payout
💵 $30 @ 8.34 USD/DOT ~ 3.597 $DOT
🧗 13s37n7Y9VvoF1JcqnQzbL2b76qb9vNQQyXvpvpProdrpvBe
🔗 0xa0f71912e177741699ec968f4415084fc595bff8c29cf76dde60a032b4183724

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 28, 2024
This was referenced Feb 29, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-visual-ok-✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable minting on RMRK/KSM
4 participants
@prury @exezbcz @yangwao @Jarsen136