-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/bug when navigating back to collection page #9540
fix/bug when navigating back to collection page #9540
Conversation
Code Climate has analyzed commit febc834 and detected 0 issues on this pull request. View more on Code Climate. |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Quality Gate passedIssues Measures |
would be interesting to know to how users interact with the collection gallery page. tested it a bit and unless you open each nft on new tab , the ux is impacted quite a lot, if the user is doing what @JustLuuuu `s video showed but idk
I feel like the option b you mention would have been a better fit regardless this also works 🚀 |
It's a trade off Loading all pages until page n would be slow to load, with speed decreasing as n increases Navigation back to top is annoying, but speedy We tried keep alive before to improve performance and it was a disaster |
fair enough. |
true open new tab with middle mouse ftw |
Thanks! |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs QA check
Context
Did your issue had any of the "$" label on it?