Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/bug when navigating back to collection page #9540

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Feb 24, 2024

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

@kodabot
Copy link
Collaborator

kodabot commented Feb 24, 2024

SUCCESS @daiagi PR for issue #9440 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

codeclimate bot commented Feb 24, 2024

Code Climate has analyzed commit febc834 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit febc834
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65d95357f0b75d00084cd29b
😎 Deploy Preview https://deploy-preview-9540--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@daiagi daiagi requested review from preschian and prury February 24, 2024 02:27
@hassnian
Copy link
Contributor

hassnian commented Feb 24, 2024

would be interesting to know to how users interact with the collection gallery page.

tested it a bit and unless you open each nft on new tab , the ux is impacted quite a lot, if the user is doing what @JustLuuuu `s video showed but idk

b. fix scrolling, when navigating to page n, all pages 0 => n should be loaded

I feel like the option b you mention would have been a better fit

regardless this also works 🚀

@daiagi
Copy link
Contributor Author

daiagi commented Feb 24, 2024

the ux is impacted quite a lot

It's a trade off

Loading all pages until page n would be slow to load, with speed decreasing as n increases

Navigation back to top is annoying, but speedy

We tried keep alive before to improve performance and it was a disaster

@hassnian
Copy link
Contributor

the ux is impacted quite a lot

It's a trade off

Loading all pages until page n would be slow to load, with speed decreasing as n increases

Navigation back to top is annoying, but speedy

We tried keep alive before to improve performance and it was a disaster

fair enough.

@prury
Copy link
Member

prury commented Feb 24, 2024

We tried keep alive before to improve performance and it was a disaster

true

open new tab with middle mouse ftw

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Feb 24, 2024
@yangwao
Copy link
Member

yangwao commented Feb 25, 2024

Thanks!
pay 30 usd

@yangwao yangwao merged commit df1d1a2 into main Feb 25, 2024
19 checks passed
@yangwao yangwao deleted the fix/going-back-to-collection-page-navigation-error branch February 25, 2024 01:02
@yangwao
Copy link
Member

yangwao commented Feb 25, 2024

😍 Perfect, I’ve sent the payout
💵 $30 @ 7.77 USD/DOT ~ 3.861 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0x2a9dcb7b6f093909ba9a6485d69547d6dffc7b4b74c7745b37b4e279bb0fee08

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 25, 2024
This was referenced Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Going back from Item Preview to Collection Preview messes up URL
6 participants