Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: little bit cleanup drops component #9534

Merged
merged 9 commits into from
Feb 26, 2024
Merged

refactor: little bit cleanup drops component #9534

merged 9 commits into from
Feb 26, 2024

Conversation

preschian
Copy link
Member

@preschian preschian commented Feb 23, 2024 •
edited
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

@preschian
refactor: little bit cleanup on drops component
624cf60
@preschian
refactor: remove unused userMintedNftId prop from various components
b0eb5c9 
fix: update raffle allocation logic in Generative and PaidGenerative components
refactor: remove unused VOTE_DROP_DESCRIPTION import in UnlockableCollectionBanner.vue
@preschian
refactor(MintSection.vue): remove availableToMint property from props
cb2fc73
@preschian
refactor: remove unused currentAccountMintedToken and collectionId fr…
3e59ff3 
…om GenerativeDropMintParams

refactor: remove currentAccountMintedToken from useDropStatus
refactor: remove userMintedNftId from useGenerativeDropMint
@preschian
fix(useGenerativeDropMint.ts): add condition check before removing it…
2a33d46 
…em from listingCartStore
@preschian
feat(MintSection.vue): remove MintSection component from the project
b83f804
@netlify Netlify
Copy link

netlify bot commented Feb 23, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d293328
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65dbc6eebc01210008876dbb
😎 Deploy Preview https://deploy-preview-9534--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@preschian
Copy link
Member Author

In this PR, I removed userMintedNftId usage. If I drill down the props, it is being used in this component.

nft-gallery/components/collection/drop/MintSection/MintSection.vue

Lines 34 to 44 in 87a8bdd

<div v-if="userMintedNftId" class="flex justify-end items-center">
<div class="mr-2">
{{ $t('mint.unlockable.nftAlreadyMinted') }}
</div>
<NeoIcon icon="circle-check text-k-green" pack="fass" class="mr-4" />
<NeoButton
class="my-2 mint-button"
:tag="NuxtLink"
:label="$t('mint.unlockable.seeYourNft')"
:to="`/${urlPrefix}/gallery/${userMintedNftId}`" />
</div>

But MintSection.vue is no longer used, I guess? There are no component imports that

cmiiw @Jarsen136 @vikiival

@Jarsen136
Copy link
Contributor

But MintSection.vue is no longer used, I guess? There are no component imports that

Yes, It's not used.

@prury
Copy link
Member

prury commented Feb 23, 2024

@preschian so far so good:
its filling the missing ids
image

next ones should be: 28 , 31 ,32
will keep going till it goes back to 42

@vikiival
Copy link
Member

Amazing work! 🩷🩷

@prury
Copy link
Member

prury commented Feb 23, 2024

done!

image

@preschian preschian marked this pull request as ready for review February 24, 2024 22:46
@vikiival
Copy link
Member

@Jarsen136 , @daiagi can I ask you for the review?

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Feb 25, 2024
@yangwao
Copy link
Member

yangwao commented Feb 25, 2024

@preschian let's resolve conflicts and we can merge it

@yangwao
Copy link
Member

yangwao commented Feb 25, 2024

Thanks, I hope it won't break something!
pay 60 usd

@yangwao
Copy link
Member

yangwao commented Feb 25, 2024

😍 Perfect, I’ve sent the payout
💵 $60 @ 7.9 USD/DOT ~ 7.595 $DOT
🧗 1xjvRADwdJcnmUCLWerEHR4iGCT5EBTm4D4fzLLg4LcAC9p
🔗 0x2ab8d86b2cddd8689cc33d44d264986d69b03db06f38f684cbd47a2b2dcdd67a

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 25, 2024
@preschian preschian requested a review from a team as a code owner February 25, 2024 23:02
@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 25, 2024

Code Climate has analyzed commit d293328 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 4

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yangwao yangwao merged commit da6e75c into main Feb 26, 2024
18 of 19 checks passed
@yangwao yangwao deleted the refactor-little-bit-cleanup-drops branch February 26, 2024 00:20
@preschian preschian mentioned this pull request Feb 27, 2024
Closed
This was referenced Feb 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@daiagi daiagi daiagi approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-resolve-merge-conflicts-🤝 S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@preschian @Jarsen136 @prury @vikiival @yangwao @daiagi