Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated NeoDropdown to tailwindcss #8350

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Migrated NeoDropdown to tailwindcss #8350

merged 7 commits into from
Dec 5, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 1, 2023 •
edited by ghost
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at b463274

Refactored NeoDropdown component and its item subcomponent to use Tailwind CSS for styling. This simplifies the code and improves the UI consistency.

🤖[deprecated] Generated by Copilot at b463274

Sing, O Muse, of the skillful refactorer
Who simplified the code of NeoDropdown
And made it shine with Tailwind's utilities
Like Hephaestus' work on Olympus' crown

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 1, 2023 19:34
@shashkovdanil shashkovdanil requested review from yangwao and removed request for a team December 1, 2023 19:34
@netlify Netlify
Copy link

netlify bot commented Dec 1, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit fc7d1d5
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/656edf23f2545000089cf6e0
😎 Deploy Preview https://deploy-preview-8350--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Dec 1, 2023

SUCCESS @shashkovdanil PR for issue #8348 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 1, 2023
@reviewpad Reviewpad
Copy link
Contributor

reviewpad bot commented Dec 1, 2023

AI-Generated Summary: This pull request involves migration of the NeoDropdown component to tailwindcss. In the process, most of the SASS specific code has been replaced with TailwindCSS utility classes in NeoDropdown.scss. Furthermore, the related changes are also reflected in NeoDropdownItem.vue file where a commented block indicating the 'active' state of the dropdown item has been removed. This implies a significant style overhaul with potentially improved maintainability and readability of the code.

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Dec 1, 2023
@prury prury requested review from preschian and removed request for yangwao December 4, 2023 13:47
@prury
Copy link
Member

prury commented Dec 4, 2023

hover not the same as canary:
image

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Dec 4, 2023
@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 4, 2023

Code Climate has analyzed commit 201985f and detected 0 issues on this pull request.

View more on Code Climate.

preschian
preschian approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@shashkovdanil
Copy link
Contributor Author

@prury fixed colors bugs

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning waiting-for-review labels Dec 4, 2023
@roiLeo roiLeo enabled auto-merge December 5, 2023 08:28
@roiLeo roiLeo added this pull request to the merge queue Dec 5, 2023
Merged via the queue into kodadot:main with commit 09d56bf Dec 5, 2023
13 of 15 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Dec 7, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@preschian preschian preschian approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration NeoDropdown to tailwindcss
5 participants
@shashkovdanil @kodabot @prury @preschian @roiLeo