Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated NeoCollapsible to tailwindcss #8343

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 1, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 6ef347a

Refactored the NeoCollapsible component to use a new design and layout, and added a storybook file for it. Removed unused NeoCollapsible.scss file.

🤖[deprecated] Generated by Copilot at 6ef347a

Oh, we're the crew of the NFT gallery
And we work on the code with skill and glee
We heave and we ho and we make it so
That the NeoCollapsible is a sight to see

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 1, 2023 16:27
@shashkovdanil shashkovdanil requested review from yangwao and removed request for a team December 1, 2023 16:27
@kodabot
Copy link
Collaborator

kodabot commented Dec 1, 2023

SUCCESS @shashkovdanil PR for issue #8342 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d8c1d61
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/656df03c24fe410007c80fb2
😎 Deploy Preview https://deploy-preview-8343--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 1, 2023
Copy link
Contributor

reviewpad bot commented Dec 1, 2023

AI-Generated Summary: This pull request includes the migration of the NeoCollapsible component to use Tailwind CSS. The corresponding style file (NeoCollapsible.scss) was deleted and the style definitions were integrated directly into the NeoCollapsible.vue file using Tailwind classes. A new story file (NeoCollapsible.story.vue) was also created to test and demonstrate this component's functionality. This results in a substantial reduction of lines of code, enhancing readability and maintainability.

@prury
Copy link
Member

prury commented Dec 4, 2023

@shashkovdanil hey, is there any reason you are removing internal dev need for review?

Copy link

codeclimate bot commented Dec 4, 2023

Code Climate has analyzed commit 337aef1 and detected 0 issues on this pull request.

View more on Code Climate.

@shashkovdanil
Copy link
Contributor Author

shashkovdanil commented Dec 4, 2023

@prury hey, what do you mean

hey, is there any reason you are removing internal dev need for review?

I don't even have the rights to do that

@prury
Copy link
Member

prury commented Dec 4, 2023

@prury hey, what do you mean

hey, is there any reason you are removing internal dev need for review?

I don't even have the rights to do that

image

prob codeowners problem :(

@prury prury requested review from preschian and roiLeo and removed request for yangwao December 4, 2023 13:43
@shashkovdanil
Copy link
Contributor Author

@prury could you change it for my other PRs please

@prury
Copy link
Member

prury commented Dec 4, 2023

@prury could you change it for my other PRs please

doing it right now

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please share histoire preview screenshot

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Dec 4, 2023
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Dec 4, 2023
@roiLeo roiLeo enabled auto-merge December 4, 2023 15:28
@roiLeo roiLeo added this pull request to the merge queue Dec 4, 2023
Merged via the queue into kodadot:main with commit f5357e5 Dec 4, 2023
12 of 15 checks passed
Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shashkovdanil
Copy link
Contributor Author

Please share histoire preview screenshot

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration NeoCollapsible to tailwindcss
5 participants