Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated NeoAutocomplete to tailwindcss #8336

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 1, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 47da901

Refactor NeoAutocomplete.scss to use TailwindCSS instead of custom CSS properties and remove unnecessary import.

🤖[deprecated] Generated by Copilot at 47da901

variable.scss
Gone with the autumn wind
TailwindCSS shines

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 1, 2023 15:32
@shashkovdanil shashkovdanil requested review from yangwao and removed request for a team December 1, 2023 15:32
Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2a8438c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/656dfe446ef719000857baa1
😎 Deploy Preview https://deploy-preview-8336--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Dec 1, 2023

SUCCESS @shashkovdanil PR for issue #8335 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 1, 2023
Copy link
Contributor

reviewpad bot commented Dec 1, 2023

AI-Generated Summary: This pull request entails migrating the NeoAutocomplete component from traditional SCSS to using tailwindcss utility classes. This shift reduces the need for explicit styles in the NeoAutocomplete.scss file, leading to the deletion of 12 lines and the addition of 3 new ones. The commit reflects the application of Tailwind's utility-first styling approach to enhance the readability and maintainability of the CSS code.

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Dec 1, 2023
@prury prury requested review from Jarsen136 and removed request for yangwao December 4, 2023 13:02
Copy link

codeclimate bot commented Dec 4, 2023

Code Climate has analyzed commit 2a8438c and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yangwao
Copy link
Member

yangwao commented Dec 4, 2023

thanks!
pay 20 usd

@yangwao yangwao merged commit e9c208f into kodadot:main Dec 4, 2023
17 checks passed
@yangwao
Copy link
Member

yangwao commented Dec 4, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 5.55 USD/DOT ~ 3.604 $DOT
🧗 16SpvdDgKNiQ3c53DxX7refnQcKUD3uRNim3Z1HBJLNGrtSP
🔗 0x78c5e7682b3bbe69a30d770cc1756e85e0e136767b02a753c7b3e8851f0b1c2b

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration NeoAutocomplete to tailwindcss
4 participants