Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 libs/ui build error #8267

Merged
merged 4 commits into from
Nov 27, 2023
Merged

🔧 libs/ui build error #8267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4d5d77
🔧 libs/ui build error
roiLeo Nov 27, 2023
4e8dc28
🧑‍💻 update code owner libs/ui
roiLeo Nov 27, 2023
d791e8c
Update .github/CODEOWNERS
vikiival Nov 27, 2023
d31503f
Merge branch 'main' into fix/ui/build
roiLeo Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
* @kodadot/code-review-guild
* @kodadot/code-review-guild
/libs/ui @kodadot/internal-dev
2 changes: 2 additions & 0 deletions libs/ui/src/components/MediaItem/type/ImageMedia.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@

<script lang="ts" setup>
import consola from 'consola'
import { defineProps, withDefaults } from 'vue'

import TheImage from '../../TheImage/TheImage.vue'
import type { ImageComponent } from '../../TheImage/TheImage.vue'

Expand Down
1 change: 1 addition & 0 deletions libs/ui/src/components/NeoAvatar/NeoAvatar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
</template>

<script setup lang="ts">
import { computed, defineProps } from 'vue'
import type { ImageComponent } from '../TheImage/TheImage.vue'
import ImageMedia from '../MediaItem/type/ImageMedia.vue'

Expand Down
1 change: 1 addition & 0 deletions libs/ui/src/components/TheImage/TheImage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import type {
MethodOptions,
ReservedProps,
} from 'vue'
import { computed, defineProps, withDefaults } from 'vue'

export type ImageComponent =
| 'img'
Expand Down
Loading