Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaItem to tailwindcss #8244

Merged
merged 7 commits into from
Dec 1, 2023
Merged

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Nov 25, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 3374f99

This pull request refactors several components in the libs/ui/src/components/MediaItem folder to use TailwindCSS instead of custom SCSS styles, to improve the UI design and performance of the NFT gallery. It also fixes some type errors, removes unused code, and updates the global styles and other components accordingly.

🤖[deprecated] Generated by Copilot at 3374f99

The MediaItem component got a makeover
With TailwindCSS to make it look bolder
No more custom SCSS
Or unused props to stress
The code is now cleaner and easier to go over

@shashkovdanil shashkovdanil requested a review from a team as a code owner November 25, 2023 14:25
@shashkovdanil shashkovdanil requested review from daiagi and Jarsen136 and removed request for a team November 25, 2023 14:25
@kodabot
Copy link
Collaborator

kodabot commented Nov 25, 2023

WARNING @shashkovdanil PR for issue #8232 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8232

Copy link

netlify bot commented Nov 25, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 6af1ea8
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/656997776b48ab0008878c3a
😎 Deploy Preview https://deploy-preview-8244--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Nov 25, 2023
Copy link
Contributor

reviewpad bot commented Nov 25, 2023

AI-Generated Summary: This pull request primarily converts styling in the MediaItem components from native SCSS to tailwindcss, and cleans up related styles. It significantly reduces lines of code by leveraging utility classes provided by tailwindcss for various properties such as dimensions, alignments, spacing, font style, and colors. The PR also changes certain class-based styles to use inline styles directly in the components. Improvements in code readability and maintenance can be expected with this change. Changes in the way particular elements such as iframe and object are styled can also improve the interface's responsiveness to varying viewport sizes.

@roiLeo roiLeo requested review from roiLeo and preschian November 25, 2023 14:29
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@shashkovdanil
Copy link
Contributor Author

hmm tests failed after merge main branch. It looks like we have broken tests in the main branch

@roiLeo
Copy link
Contributor

roiLeo commented Nov 27, 2023

hmm tests failed after merge main branch. It looks like we have broken tests in the main branch

ref #8265

@daiagi
Copy link
Contributor

daiagi commented Nov 28, 2023

colides with #8274 doesn't it?

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we merge #8274 first since I'm moving MediaItem inside koda repo?

@shashkovdanil
Copy link
Contributor Author

@roiLeo I guess it doesn't matter, I'll fix conflicts

@shashkovdanil
Copy link
Contributor Author

Let's merge your branch first then I'll fix conflicts

@shashkovdanil shashkovdanil requested a review from a team as a code owner November 28, 2023 16:31
@shashkovdanil
Copy link
Contributor Author

@roiLeo fixed conficts

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

@shashkovdanil shashkovdanil requested a review from roiLeo November 29, 2023 11:09
@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Nov 29, 2023
@reviewpad reviewpad bot added medium Pull request is medium and removed large Pull request is large labels Nov 29, 2023
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Nov 29, 2023
Copy link

codeclimate bot commented Nov 29, 2023

Code Climate has analyzed commit b510185 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo added this pull request to the merge queue Dec 1, 2023
Merged via the queue into kodadot:main with commit fd7c95b Dec 1, 2023
13 of 15 checks passed
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration MediaItem to tailwindcss
5 participants