-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MediaItem to tailwindcss #8244
MediaItem to tailwindcss #8244
Conversation
WARNING @shashkovdanil PR for issue #8232 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8232 |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request primarily converts styling in the MediaItem components from native SCSS to tailwindcss, and cleans up related styles. It significantly reduces lines of code by leveraging utility classes provided by tailwindcss for various properties such as dimensions, alignments, spacing, font style, and colors. The PR also changes certain class-based styles to use inline styles directly in the components. Improvements in code readability and maintenance can be expected with this change. Changes in the way particular elements such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
hmm tests failed after merge main branch. It looks like we have broken tests in the main branch |
ref #8265 |
colides with #8274 doesn't it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we merge #8274 first since I'm moving MediaItem
inside koda repo?
@roiLeo I guess it doesn't matter, I'll fix conflicts |
Let's merge your branch first then I'll fix conflicts |
@roiLeo fixed conficts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
This reverts commit 5973601.
Code Climate has analyzed commit b510185 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
MediaItem
totailwindcss
#8232Before submitting pull request, please make sure:
Optional
Did your issue had any of the "$" label on it?
Community participation
Screenshot 📸
Copilot Summary
🤖[deprecated] Generated by Copilot at 3374f99
This pull request refactors several components in the
libs/ui/src/components/MediaItem
folder to use TailwindCSS instead of custom SCSS styles, to improve the UI design and performance of the NFT gallery. It also fixes some type errors, removes unused code, and updates the global styles and other components accordingly.🤖[deprecated] Generated by Copilot at 3374f99