Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CardArticle to tailwindcss #8229

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Nov 24, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

Copilot Summary

🤖[deprecated] Generated by Copilot at 889ee0f

Refactored CardArticle component to use Tailwind CSS for better design and performance. Deleted unused style file.

🤖[deprecated] Generated by Copilot at 889ee0f

<style> tag gone
Card component refactored
Tailwind brings spring breeze

@shashkovdanil shashkovdanil requested a review from a team as a code owner November 24, 2023 00:29
@shashkovdanil shashkovdanil requested review from daiagi and Jarsen136 and removed request for a team November 24, 2023 00:29
Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit a67f960
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/656087225399500008901ee4
😎 Deploy Preview https://deploy-preview-8229--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Nov 24, 2023

SUCCESS @shashkovdanil PR for issue #8223 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link
Contributor

reviewpad bot commented Nov 24, 2023

AI-Generated Summary: This pull request deletes the SCSS file for the CardArticle component and transitions the styling work to Tailwind CSS within the CardArticle.vue file. It significantly reduces the code lines in the patch from 54 to 8. The changes revolve around replacing class names with the corresponding Tailwind utility classes, adjusting properties and behavior such as hover effects, object fit and padding, as well as removing scoped SCSS import at the end. The update is part of an effort to improve code maintainability and embrace utility-first CSS methodology.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Nov 24, 2023
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before
Screenshot 2023-11-24 at 08-39-21 KodaDot - NFT Market Explorer

after
Screenshot 2023-11-24 at 08-39-30 KodaDot - NFT Market Explorer

need some small changes on border & hover state

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -140,4 +140,10 @@
--toggle-primary: var(--white);
--toggle-active-switch: #363234;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codeclimate bot commented Nov 24, 2023

Code Climate has analyzed commit a67f960 and detected 0 issues on this pull request.

View more on Code Climate.

@shashkovdanil shashkovdanil requested a review from roiLeo November 24, 2023 11:21
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Nov 24, 2023
@yangwao
Copy link
Member

yangwao commented Nov 24, 2023

Thanks!
pay 30 usd

@yangwao yangwao merged commit 9c889f4 into kodadot:main Nov 24, 2023
17 checks passed
@yangwao
Copy link
Member

yangwao commented Nov 24, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 5.23 USD/DOT ~ 5.736 $DOT
🧗 16SpvdDgKNiQ3c53DxX7refnQcKUD3uRNim3Z1HBJLNGrtSP
🔗 0xd9ea1bf48d5b31083a12974ee527d964d1fa63766311969efdc95c0c6a5fea5f

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 24, 2023
This was referenced Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration CardArticle to tailwindcss
4 participants