Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new teleport page #7946

Merged
merged 12 commits into from
Nov 8, 2023
Merged

feat: new teleport page #7946

merged 12 commits into from
Nov 8, 2023

Conversation

newraina
Copy link
Member

@newraina newraina commented Nov 4, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

CleanShot 2023-11-05-D5WCxjMR@2x

Copilot Summary

🤖 Generated by Copilot at 44b9d94

This pull request enhances the teleport feature by adding new components, icons, input fields and localization strings. It modifies the Teleport.vue component and its related files, such as NetworkDropdown.vue, locales/en.json and utils/chain.ts. The goal is to improve the user interface and experience of teleporting assets across networks.

🤖 Generated by Copilot at 44b9d94

To teleport assets with ease
We added some dropdowns and keys
NetworkDropdown.vue
And locales/en.json too
And some icons for networks like dot and kusama

@kodabot
Copy link
Collaborator

kodabot commented Nov 4, 2023

SUCCESS @newraina PR for issue #7363 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Nov 4, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit b553e9c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/654a287ebb53a000084eb330
😎 Deploy Preview https://deploy-preview-7946--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Nov 4, 2023

AI-Generated Summary: This pull request introduces a new teleport page to the existing site code. It involves a substantial update to the Teleport.vue file, which defines the layout and functionality of the site's teleport feature. This update includes the addition of a NetworkDropdown.vue file and SVG icons for chain networks featuring in the teleport ability. The NetworkDropdown file creates a dropdown-select feature for users to specify their desired network for the teleport feature, with associated SVG icons for these networks.

The modifications also include additions to the locales/en.json file to reflect new text labels like "source chain", "destination", "asset amount", etc., to be displayed on the teleport page. Furthermore, the chain.ts utility file has been updated to include Polkadot network in the chain icon mappings.

Overall, 252 insertions were added and 93 deletions made, with components/teleport/NetworkDropdown.vue and public/teleport/arrow.svg were newly created.

utils/chain.ts Show resolved Hide resolved
@reviewpad reviewpad bot added the large Pull request is large label Nov 4, 2023
@exezbcz
Copy link
Member

exezbcz commented Nov 4, 2023

hello! thank you for this pr

some things I saw right away

image

  • only display networks possible to teleport to

dark mode needs some work
image

@newraina newraina marked this pull request as ready for review November 5, 2023 03:26
@newraina newraina requested a review from a team as a code owner November 5, 2023 03:26
@newraina newraina requested review from roiLeo and floyd-li and removed request for a team November 5, 2023 03:26
@newraina
Copy link
Member Author

newraina commented Nov 5, 2023

@exezbcz fixed. It was a draft PR yesterday, you can review it again now

@prury
Copy link
Member

prury commented Nov 6, 2023

small thing on firefox:
image

apart from that works nicely!

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Nov 6, 2023
@exezbcz
Copy link
Member

exezbcz commented Nov 6, 2023

nice job! works for me, just the few little things prury mentioned

I will probably create a small followup, feel free to pickup that as well 🚀

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm

note: divider is not full width on mobile

Screenshot 2023-11-07 at 10-12-19 KodaDot - NFT Market Explorer

components/teleport/NetworkDropdown.vue Outdated Show resolved Hide resolved
components/teleport/NetworkDropdown.vue Show resolved Hide resolved
components/teleport/Teleport.vue Outdated Show resolved Hide resolved
components/teleport/Teleport.vue Outdated Show resolved Hide resolved
newraina and others added 2 commits November 7, 2023 18:39
@newraina
Copy link
Member Author

newraina commented Nov 7, 2023

@roiLeo

note: divider is not full width on mobile

it's on purpose. The dividing line in the design isn't full width:

CleanShot 2023-11-07-bXKqd2Cl@2x

@roiLeo
Copy link
Contributor

roiLeo commented Nov 7, 2023

it's on purpose. The dividing line in the design isn't full width:

noted! weird but ok

components/teleport/Teleport.vue Show resolved Hide resolved
components/teleport/Teleport.vue Outdated Show resolved Hide resolved
components/teleport/Teleport.vue Outdated Show resolved Hide resolved
@newraina
Copy link
Member Author

newraina commented Nov 7, 2023

@prury

small thing on firefox: image

Made a little change, now on my Firefox:
CleanShot 2023-11-07-vdKZj4yb@2x

@exezbcz
Copy link
Member

exezbcz commented Nov 7, 2023

@roiLeo lel, yeah you can make it full width, I think its because I resized the auto layout and left it like this.

my bad

Copy link

codeclimate bot commented Nov 7, 2023

Code Climate has analyzed commit b553e9c and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@newraina
Copy link
Member Author

newraina commented Nov 7, 2023

@roiLeo lel, yeah you can make it full width, I think its because I resized the auto layout and left it like this.

@exezbcz oh I thought it was a special design. fixed

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Nov 7, 2023
@exezbcz exezbcz mentioned this pull request Nov 7, 2023
@yangwao
Copy link
Member

yangwao commented Nov 8, 2023

Thanks!
pay 70 usd

@yangwao yangwao merged commit 975a3af into kodadot:main Nov 8, 2023
10 of 11 checks passed
@yangwao
Copy link
Member

yangwao commented Nov 8, 2023

😍 Perfect, I’ve sent the payout
💵 $70 @ 4.99 USD/DOT ~ 14.028 $DOT
🧗 1CAv6Zq3yVxL3eKhC94GWTWVwp1w4jZbqeZ6wXx1rPAhrce
🔗 0x89bf0f748361aaaf445dd7349596fe75937af5216ea7b04bb07a17e5f4a73cd7

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 8, 2023
This was referenced Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teleport v2 improvements
6 participants