-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new teleport page #7946
feat: new teleport page #7946
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request introduces a new teleport page to the existing site code. It involves a substantial update to the Teleport.vue file, which defines the layout and functionality of the site's teleport feature. This update includes the addition of a NetworkDropdown.vue file and SVG icons for chain networks featuring in the teleport ability. The NetworkDropdown file creates a dropdown-select feature for users to specify their desired network for the teleport feature, with associated SVG icons for these networks. The modifications also include additions to the locales/en.json file to reflect new text labels like "source chain", "destination", "asset amount", etc., to be displayed on the teleport page. Furthermore, the chain.ts utility file has been updated to include Polkadot network in the chain icon mappings. Overall, 252 insertions were added and 93 deletions made, with components/teleport/NetworkDropdown.vue and public/teleport/arrow.svg were newly created. |
@exezbcz fixed. It was a draft PR yesterday, you can review it again now |
nice job! works for me, just the few little things prury mentioned I will probably create a small followup, feel free to pickup that as well 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: roiLeo <[email protected]>
Co-authored-by: roiLeo <[email protected]>
it's on purpose. The dividing line in the design isn't full width: |
noted! weird but ok |
|
@roiLeo lel, yeah you can make it full width, I think its because I resized the auto layout and left it like this. my bad |
Code Climate has analyzed commit b553e9c and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Thanks! |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Did your issue had any of the "$" label on it?
Community participation
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at 44b9d94
This pull request enhances the teleport feature by adding new components, icons, input fields and localization strings. It modifies the
Teleport.vue
component and its related files, such asNetworkDropdown.vue
,locales/en.json
andutils/chain.ts
. The goal is to improve the user interface and experience of teleporting assets across networks.🤖 Generated by Copilot at 44b9d94