Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch network #6473

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix: switch network #6473

merged 1 commit into from
Jul 28, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Jul 26, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs check

Context

Copilot Summary

🤖 Generated by Copilot at 1f3588d

This pull request improves the navbar component and its related components and tests. It adds a data-cy attribute for Cypress testing, modifies the pagination props, makes some props optional, refactors some props, removes a redundant attribute, and changes the prefix fallback logic. It also adds a new test file for the prefix switching feature.

🤖 Generated by Copilot at 1f3588d

Navbar component
Enhanced with props and tests
Autumn of refactor

@kodabot
Copy link
Collaborator

kodabot commented Jul 26, 2023

SUCCESS @preschian PR for issue #6472 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 1f3588d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64c0de2b116523000890be9c
😎 Deploy Preview https://deploy-preview-6473--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codeclimate
Copy link

codeclimate bot commented Jul 26, 2023

Code Climate has analyzed commit 1f3588d and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 26, 2023

AI-Generated Summary: This pull request includes modifications to various Vue.js components, a change in usePrefix.ts, and a new Cypress test file prefix.cy.ts related to network switching. Briefly, the changes are:

  1. In several Vue.js components, the pull request modifies the props types or default values for improved flexibility and error handling, for instance, making certain props optional or adjusting their default values.

  2. In the usePrefix.ts, the order of prefix selection has been altered.

  3. A new Cypress testing file (prefix.cy.ts) has been introduced to provide end-to-end testing for the network switching feature.

  4. Certain elements have been assigned data-cy attributes, usually used as selectors in Cypress for more targeted testing.

  5. There are also minor amendments, such as changes to the fields accessed in some components, for instance, in NeoNftCard.vue where name is accessed as nft.name.

Overall, these changes aim to improve code functioning, test coverage, and simplicity.

@reviewpad reviewpad bot added the small Pull request is small label Jul 26, 2023
@preschian preschian marked this pull request as ready for review July 26, 2023 09:10
@preschian preschian requested a review from a team as a code owner July 26, 2023 09:10
@preschian preschian requested review from roiLeo and vikiival and removed request for a team July 26, 2023 09:10
@preschian preschian requested a review from prury July 27, 2023 06:06
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 27, 2023
@prury
Copy link
Member

prury commented Jul 27, 2023

@preschian thanks for writing a cypress test for it!

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jul 27, 2023
@yangwao yangwao merged commit c91746a into main Jul 28, 2023
@yangwao yangwao deleted the fix/switch-network branch July 28, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't change network after accessing gallery item
5 participants