Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tags on RMRK NFTs #3792

Merged
merged 9 commits into from
Aug 25, 2022
Merged

fix: Tags on RMRK NFTs #3792

merged 9 commits into from
Aug 25, 2022

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested review from a team as code owners August 19, 2022 14:29
@Jarsen136 Jarsen136 requested review from roiLeo and JustLuuuu and removed request for a team August 19, 2022 14:29
@netlify
Copy link

netlify bot commented Aug 19, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 6e1d606
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63077d8100b1330009b8f142
😎 Deploy Preview https://deploy-preview-3792--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Aug 19, 2022

SUCCESS @Jarsen136 PR for issue #3765 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@roiLeo
Copy link
Contributor

roiLeo commented Aug 19, 2022

How does it work? Where can we test this?

@petersopko
Copy link
Contributor

How does it work? Where can we test this?

you mint NFT with selected tags and test whether they are included in metadata of the NFT at https://app.gc.subsquid.io/beta/rubick/007/graphql and now, whether they are showing with @Jarsen136's implementation

Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now something gets saved, but is this the way it should work? 👀

image

"meta": {
              "attributes": [
                {
                  "display": "undefined",
                  "trait": "undefined",
                  "value": "image"
                },
                {
                  "display": "undefined",
                  "trait": "undefined",
                  "value": "dall·e"
                },
                {
                  "display": "undefined",
                  "trait": "undefined",
                  "value": "generative"
                },
                {
                  "display": "undefined",
                  "trait": "carbonless",
                  "value": "1"
                }
              ]
            }

@petersopko petersopko added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Aug 19, 2022
@Jarsen136
Copy link
Contributor Author

now something gets saved, but is this the way it should work? 👀

image

I think it's not.
By the way, I wonder what's name of the key should be shown when user selected some tag 🤔

@Jarsen136
Copy link
Contributor Author

I guess it's better now with the redesign of the property component.
image

@Jarsen136 Jarsen136 requested a review from petersopko August 23, 2022 01:42
@roiLeo
Copy link
Contributor

roiLeo commented Aug 25, 2022

I have doubts about the correct functioning, as this been tested on mint?

@codeclimate
Copy link

codeclimate bot commented Aug 25, 2022

Code Climate has analyzed commit 6e1d606 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

I have doubts about the correct functioning, as this been tested on mint?

Yup, petersopko have tested on rmrk. I have tested on bsx as well. It works well on minting.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm
Screenshot 2022-08-25 at 16-01-38 Placeholder KodaDot - Kusama NFT Market Explorer

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 25, 2022
@yangwao
Copy link
Member

yangwao commented Aug 25, 2022

pay 50 usd

@yangwao yangwao merged commit 170a269 into kodadot:main Aug 25, 2022
@yangwao
Copy link
Member

yangwao commented Aug 25, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 48.63 USD/KSM ~ 1.028 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x6be1c14cea661eea68fdc9338e410f221b7174f12a9c16dabf5ab6c93964dc1a

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-changes-requested-🤞 PR is almost good to go, just some fine tunning S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags on RMRK NFTs
5 participants