-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Tags on RMRK NFTs #3792
fix: Tags on RMRK NFTs #3792
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
SUCCESS @Jarsen136 PR for issue #3765 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
How does it work? Where can we test this? |
you mint NFT with selected tags and test whether they are included in metadata of the NFT at https://app.gc.subsquid.io/beta/rubick/007/graphql and now, whether they are showing with @Jarsen136's implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now something gets saved, but is this the way it should work? 👀
"meta": {
"attributes": [
{
"display": "undefined",
"trait": "undefined",
"value": "image"
},
{
"display": "undefined",
"trait": "undefined",
"value": "dall·e"
},
{
"display": "undefined",
"trait": "undefined",
"value": "generative"
},
{
"display": "undefined",
"trait": "carbonless",
"value": "1"
}
]
}
I have doubts about the correct functioning, as this been tested on mint? |
Code Climate has analyzed commit 6e1d606 and detected 0 issues on this pull request. View more on Code Climate. |
Yup, petersopko have tested on rmrk. I have tested on bsx as well. It works well on minting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pay 50 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type
What's new?
Before submitting Pull Request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot