Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mass minting drops on evm #10967

Merged
merged 3 commits into from
Sep 16, 2024
Merged

feat: Mass minting drops on evm #10967

merged 3 commits into from
Sep 16, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Sep 11, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  1. should work but I've not executed any transaction since I don't have a test drop to use
  2. GENSOL_ABI is not deleted since it's used in other places like burning, listing etc, should that also use the fetched abi?

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-09-11 at 14 28 11@2x

CleanShot 2024-09-13 at 10 00 57@2x

@hassnian hassnian requested a review from preschian September 11, 2024 09:27
@hassnian hassnian requested a review from a team as a code owner September 11, 2024 09:27
@hassnian hassnian requested review from Jarsen136 and removed request for a team September 11, 2024 09:27
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c6f3171
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66e4183f542fd4000747e701
😎 Deploy Preview https://deploy-preview-10967--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

GENSOL_ABI is not deleted since it's used in other places like burning, listing etc, should that also use the fetched abi?

yes, I would prefer fetch abi endpoint instead. we can address this on separate PR

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@hassnian hassnian added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Sep 13, 2024
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing <33

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@hassnian
Copy link
Contributor Author

merging since

CleanShot 2024-09-16 at 09 48 00@2x

and worked for everyone

CleanShot 2024-09-13 at 10 00 57@2x

@hassnian hassnian added this pull request to the merge queue Sep 16, 2024
Merged via the queue into kodadot:main with commit ef537f2 Sep 16, 2024
20 of 22 checks passed
@hassnian hassnian deleted the issue-10815 branch September 16, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mass minting drops on evm
4 participants