-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: collection/gallery explore page images #10443
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Quality Gate passedIssues Measures |
@preschian should we remove also some images fail to load like image worker ✅ https://image-beta.w.kodadot.xyz/ipfs/bafybeiaq2lvwomxmtmqyr5yigi4mty7ybib4myqewv6c265aheqv6lvjgu |
Yes, this one can help reduce the request counts. But we need to implement cfi size variants in image-worker first
if the |
done, needs worker update kodadot/workers#313
worked fine for me, @prury let's try again after kodadot/workers#313 is merged |
@prury the worker is ready, try again and let me know |
cc @Jarsen136 pls review |
done |
same here
|
done |
One test is failing @hassnian |
Code Climate has analyzed commit eb663f0 and detected 0 issues on this pull request. View more on Code Climate. |
PR Type
Context
First pr of more to come to close the main issue, this pr only focuses on the explore pages
mainly
Collection Explore
- mobile: 2.5mb (this pr) vs 19.8mb (prod)
- desktop: 3mb (this pr) vs 19.8mb (prod)
metadata
from collectionmeta
, saves an extra call, most collections didn't need that (ahp 87/94 collections),Items Explore
lazy load images: eagerly load first 2 rows of each fetch remaining are lazy loaded
Ref Request heavy app - high amount of fetches #10416
Needs QA check
Did your issue had any of the "$" label on it?
Screenshot 📸