Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Variables for theming #4584

Closed
prachi00 opened this issue Jan 2, 2023 · 2 comments · Fixed by #4579 or #4855
Closed

CSS Variables for theming #4584

prachi00 opened this issue Jan 2, 2023 · 2 comments · Fixed by #4579 or #4855
Labels
$ ~<50usd enhancement New feature or request p3 non-core, affecting less than 40%

Comments

@prachi00
Copy link
Member

prachi00 commented Jan 2, 2023

    @roiLeo @yangwao @vikiival @Jarsen136 @petersopko @preschian 

I am really tired of writing double css, once in light mode and then in dark mode, I researched and figured this would be the best way to make sure that css is only written once for all themes
With this approach, we can get rid of _Dark.scss and _light.scss files

Let me know if this seems okay to you, or you would prefer some other way of doing it?
I couldnt really find anything for using scss variables theming directly without any mixins

I have some time because of the holidays going on, I can do this transition, I feel like it would speed up our development by doing this once and for all

Originally posted by @prachi00 in #4579 (comment)

@prachi00
Copy link
Member Author

prachi00 commented Jan 2, 2023

Waiting for more inout before I start working on this :)

@yangwao yangwao added enhancement New feature or request $ ~<50usd p3 non-core, affecting less than 40% labels Jan 2, 2023
@yangwao
Copy link
Member

yangwao commented Jan 2, 2023

I really appreciate the effort to make it easier to manage code.
Hence we are getting a bit complex app, and with the redesign on top, I see a lot of quirky back-and-forth visual conflicts repeating.
I would nominate for suggestions from others; probably @roiLeo @preschian @Jarsen136 can have some great suggestions and the best approach. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd enhancement New feature or request p3 non-core, affecting less than 40%
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants