Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing border on dialog for qr-code scanner on profile and collection #1100

Closed
yangwao opened this issue Nov 11, 2021 · 2 comments · Fixed by #1631
Closed

Missing border on dialog for qr-code scanner on profile and collection #1100

yangwao opened this issue Nov 11, 2021 · 2 comments · Fixed by #1631
Labels
A-collection work being done collection view bug Something isn't working p3 non-core, affecting less than 40%

Comments

@yangwao
Copy link
Member

yangwao commented Nov 11, 2021

https://kodadot.xyz/rmrk/collection/10c369c57194165634-92YIT
image

https://kodadot.xyz/rmrk/u/CxJLK5bYbVQgH7r1axUbxymmaQhUoMPkTfuvQsb2djehgVU
image
@yangwao yangwao added bug Something isn't working p3 non-core, affecting less than 40% labels Nov 11, 2021
@yangwao yangwao changed the title Missing border for qr-code scanner on profile and collection Missing border on dialog for qr-code scanner on profile and collection Nov 11, 2021
@yangwao yangwao added the A-collection work being done collection view label Nov 11, 2021
@XyloDrone
Copy link

IMO a border isn't needed here, but I differ.

@roiLeo
Copy link
Contributor

roiLeo commented Dec 16, 2021 •
edited
Loading

There is a border because of the global css defined in GalleryItem component. By default, there should be none.

#1348 related

edit: would be nice to have a closing button in modal

@roiLeo roiLeo mentioned this issue Dec 29, 2021
Merged
2 tasks
@roiLeo roiLeo mentioned this issue Dec 30, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-collection work being done collection view bug Something isn't working p3 non-core, affecting less than 40%
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⚒️ remove unused css & fix border on qr code roiLeo/nft-gallery
3 participants
@yangwao @roiLeo @XyloDrone