o2dlm-fix-null-pointer-dereference-in-o2dlm_blocking_ast_wrapper-chec…

…kpatch-fixes WARNING: else is not generally useful after a break or return torvalds#47: FILE: fs/ocfs2/dlm/dlmast.c:392: + break; + else total: 0 errors, 1 warnings, 15 lines checked ./patches/o2dlm-fix-null-pointer-dereference-in-o2dlm_blocking_ast_wrapper.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Joel Becker <[email protected]> Cc: Mark Fasheh <[email protected]> Cc: Srinivas Eeda <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
koct9i · Sep 26, 2014 · fa7e6d7 · fa7e6d7
1 parent b4a536d
commit fa7e6d7
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/fs/ocfs2/dlm/dlmast.c b/fs/ocfs2/dlm/dlmast.c
@@ -389,8 +389,7 @@ int dlm_proxy_ast_handler(struct o2net_msg *msg, u32 len, void *data,
 		if (lock->ml.cookie == cookie) {
 			if (lock->unlock_pending)
 				break;
-			else
-				goto do_ast;
+			goto do_ast;
 		}
 	}