Reduce the possible minimal grace period. #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latest changes we've done to the scale to zero behavior, especially in the face of the Activator being in the path for TBC work, it is possible to have quite short Grace windows. This change permits it to be as small as minimal window. This should help everyone who wants faster shutdowns. For knative#4453 The integration test to test all this is in progress...
knative-prow-robot
added
size/XS
|
/test pull-knative-serving-unit-tests unrelated |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonjohnsonjr, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest changes we've done to the scale to zero behavior, especially in the face of the
Activator being in the path for TBC work, it is possible to have quite short Grace windows.
This change permits it to be as small as minimal window.
Due to the network delays, the default value is recommended to be kept as is at 30s, unless you know what you're doing.
This should help everyone who wants faster shutdowns, though.
For #4453
/assign @jonjohnsonjr