Make scale down to 0 even faster in some cases. #4938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the single request activation it might happen that we end up here earlier than stable period. In that case, e.g. with window of 60 seconds, which is the default, we'd wait another whole minute. This way we'll wait on the remaining time (usually under a second).
knative-prow-robot
added
the
size/M
knative-prow-robot
added
approved
|
Cool |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonjohnsonjr, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| // Otherwise, scale down to 1 until the idle period elapses and re-enqueue | ||
| // the PA for reconciliation at that time. | ||
| ks.enqueueCB(pa, sw) | ||
| // Otherwise, scale down to at most 1 for the remainder of the idle period and then |
There was a problem hiding this comment.
Eh, since this is scale to 0, so "at most 1", as in no more than 1, but still not 0...
Perhaps just "scale to 1".
|
/retest |
|
/test pull-knative-serving-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the single request activation it might happen that we end up
here earlier than stable period. In that case, e.g. with window of 60 seconds,
which is the default, we'd wait another whole minute.
This way we'll wait on the remaining time (usually under a second).
/assign @jonjohnsonjr
For #4453