Introduce the metric controller. #4913
Conversation
The metric controller reacts on the lifecycle of metric objects and currently makes sure that metric collecting is started when a metric is created and stopped if one is deleted. As updating is not really a distinct use-case we want to handle differently, this also introduces a 'CreateOrUpdate' function to the collector, which appropriately acts if the collection was already running or not. This is a stepping stone towards removing the in-memory handling of metric entities. The controller is not yet hooked up though.
knative-prow-robot
added
size/L
There was a problem hiding this comment.
@markusthoemmes: 0 warnings.
In response to this:
Ref #4403
Proposed Changes
The metric controller reacts on the lifecycle of metric objects and currently makes sure that metric collecting is started when a metric is created and stopped if one is deleted. As updating is not really a distinct use-case we want to handle differently, this also introduces a 'CreateOrUpdate' function to the collector, which appropriately acts if the collection was already running or not.
This is a stepping stone towards removing the in-memory handling of metric entities. The controller is not yet hooked up though.
Release Note
NONE/assign @vagababov
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ref #4403
Proposed Changes
The metric controller reacts on the lifecycle of metric objects and currently makes sure that metric collecting is started when a metric is created and stopped if one is deleted. As updating is not really a distinct use-case we want to handle differently, this also introduces a 'CreateOrUpdate' function to the collector, which appropriately acts if the collection was already running or not.
This is a stepping stone towards removing the in-memory handling of metric entities. The controller is not yet hooked up though.
Release Note
/assign @vagababov