Add changes to validate annotation for revision templates #4888
Conversation
knative-prow-robot
added
area/API
There was a problem hiding this comment.
@savitaashture: 0 warnings.
In response to this:
Fixes #4782
Proposed Changes
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
Hi @savitaashture. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow-robot
added
the
needs-ok-to-test
| @@ -572,3 +573,91 @@ func TestImmutableFields(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestRevisionTemplateSpecValidation(t *testing.T) { | |||
There was a problem hiding this comment.
Interesting that this was missing all along. Any reason why you didn't copy all of the tests over?
There was a problem hiding this comment.
I dint copy test case related to serving.QueueSideCarResourcePercentageAnnotation
because in v1beta/revision_validation.go we dont have this logic
https://github.com/knative/serving/blob/master/pkg/apis/serving/v1alpha1/revision_validation.go#L87 so test case related to this i have skipped.
I wanted to know like why we have not added https://github.com/knative/serving/blob/master/pkg/apis/serving/v1alpha1/revision_validation.go#L87 in v1beta1
Any reason?
There was a problem hiding this comment.
This seems like a bug. We should not have difference in annotations here between the two versions.
There was a problem hiding this comment.
I submitted a bug to track this and keep this PR scoped to just this feature. #4903
|
/ok-to-test |
knative-prow-robot
added
ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgerd, savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Fixes #4782
Proposed Changes
#4782 (comment)