Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the metric to report excess burst capacity. #4758

Merged
merged 3 commits into from
Jul 16, 2019

Conversation

vagababov
Copy link
Contributor

This reports excess burst capacity from the autoscaler.
Next change will contain the Graphana config changes
so we can plot those by default.

/assign @markusthoemmes @yanweiguo

/lint

This reports excess burst capacity from the autoscaler.
Next change will contain the Graphana config changes
so we can plot those by default.

/assign @markusthoemmes @yanweiguo
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 16, 2019
@knative-prow-robot knative-prow-robot added area/autoscale size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 16, 2019
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagababov: 0 warnings.

In response to this:

This reports excess burst capacity from the autoscaler.
Next change will contain the Graphana config changes
so we can plot those by default.

/assign @markusthoemmes @yanweiguo

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2019
@vagababov
Copy link
Contributor Author

/retest

pkg/autoscaler/stats_reporter.go Outdated Show resolved Hide resolved
pkg/autoscaler/stats_reporter.go Outdated Show resolved Hide resolved
pkg/autoscaler/stats_reporter.go Outdated Show resolved Hide resolved
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit cc022d6 into knative:master Jul 16, 2019
@vagababov vagababov deleted the ebc-metric branch September 20, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants