Fix autoscale image and remove bloatingcow image. #4687
Conversation
- The usages of the autoscale images provided it with query parameters to control the sleep duration etc. All of that was defunct. - The sample autoscale image also contains code for bloating memory. As that's useful for autoscale testing, move it into the image here is well and remove the bloatingcow image.
knative-prow-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
There was a problem hiding this comment.
@markusthoemmes: 1 warning.
In response to this:
Proposed Changes
- The usages of the autoscale images provided it with query parameters to control the sleep duration etc. All of that was defunct.
- The sample autoscale image also contains code for bloating memory. As that's useful for autoscale testing, move it into the image here is well and remove the bloatingcow image.
Release Note
NONE/assign @vagababov
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
| p := primes(max) | ||
| if len(p) > 0 { | ||
| return fmt.Sprintf("The largest prime less than %v is %v.\n", max, p[len(p)-1]) | ||
| } else { |
There was a problem hiding this comment.
Golint indent: if block ends with a return statement, so drop this else and outdent its block. More info.
knative-prow-robot
added
the
area/test-and-release
|
/test pull-knative-serving-integration-tests Unrelated I think. |
|
/test pull-knative-serving-smoke-tests |
|
Pod pending timeout? 🤔 /test pull-knative-serving-integration-tests |
|
/test pull-knative-serving-integration-tests |
|
what the?! /test pull-knative-serving-integration-tests |
Proposed Changes
Release Note
/assign @vagababov