Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of the target burst capacity annotation. #4669

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Implementation of the target burst capacity annotation. #4669

merged 1 commit into from
Jul 10, 2019

Conversation

vagababov
Copy link
Contributor

THis matches the behaviour in the config map.

/assign @mattmoor

Fixes #4450

/lint

@vagababov
Implementation of the target burst capacity annotation.
d2a8126 
THis matches the behaviour in the config map.

/assign @mattmoor

Fixes knative#4450
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 9, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2019
knative-prow-robot
knative-prow-robot reviewed Jul 9, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagababov: 0 warnings.

In response to this:

THis matches the behaviour in the config map.

/assign @mattmoor

Fixes #4450

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/autoscale approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 9, 2019
mattmoor
mattmoor reviewed Jul 9, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/autoscaling/v1alpha1/pa_lifecycle.go 98.0% 98.1% 0.0

@mattmoor
Copy link
Member

/retest

@vagababov
Copy link
Contributor Author

/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot merged commit c5de62a into knative:master Jul 10, 2019
@vagababov vagababov deleted the 4450-p2 branch September 2, 2019 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@mattmoor mattmoor mattmoor left review comments

@josephburnett josephburnett Awaiting requested review from josephburnett

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Target Utilization must be possible to set per revision
5 participants
@vagababov @knative-prow-robot @knative-metrics-robot @mattmoor @googlebot