-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queue ReadinessProbe Kubelet Header e2e Test #4667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshrider: 0 warnings.
In response to this:
- e2e test verifies that readiness probe receives kube-probe header
Co-authored-by: Joshua Rider [email protected]
Supports #4649
Proposed Changes
- changes the
/_healthz
endpoint of theruntime
test image to/healthz
.- changes
/healthz
path ofruntime
test image to return HTTP Status 400 if kubelet's User-Agent headers are not present- adds an end-to-end test with a
ReadinessProbe
hittingruntime
's/healthz
path to verify the queue-proxy's addition of kubelet's User-Agent headerRelease Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/assign @mattmoor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit about placement otherwise LGTM. thanks!
- e2e test verifies that readiness probe receives kube-probe header Co-authored-by: Shash Reddy <[email protected]>
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
@mattmoor : Moved the file to conformance package. Ready for another review 👍 |
/test pull-knative-serving-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joshrider, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Co-authored-by: Joshua Rider [email protected]
Supports #4649
Proposed Changes
/_healthz
endpoint of theruntime
test image to/healthz
./healthz
path ofruntime
test image to return HTTP Status 400 if kubelet's User-Agent headers are not presentReadinessProbe
hittingruntime
's/healthz
path to verify the queue-proxy's addition of kubelet's User-Agent headerRelease Note