Implement TU on annotaion. #4656
Conversation
We need target utilization on annation so that operators are able to set the value per-revision in line with other PA knobs /assign @markusthoemmes
knative-prow-robot
added
the
size/L
There was a problem hiding this comment.
@vagababov: 1 warning.
In response to this:
We need target utilization on annation so that operators are able to set
the value per-revision in line with other PA knobs/assign @markusthoemmes @mattmoor
/lint
Fixes #4450
Adds new annotation to control TU on the revision
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
approved
pkg/apis/autoscaling/register.go
Outdated
| // Valid values are -1 and 0 <= TBC <= MaxInt32, where -1 is the infinite | ||
| // capacity, and 0 no desired burst capacity. | ||
| // This annotation takes precedence over the config map value. | ||
| TargetBurstCapacityKey = GroupName + "/targetBurstCapacity" |
There was a problem hiding this comment.
I can remove it from current PR, though and re-introduce in the next one.
| // Window returns the window annotation value or false if not present. | ||
| func (pa *PodAutoscaler) Window() (window time.Duration, ok bool) { | ||
| if s, ok := pa.Annotations[autoscaling.WindowAnnotationKey]; ok { | ||
| // The value is already validated in the webhook. |
There was a problem hiding this comment.
So these are not validated in the Webhook?
There was a problem hiding this comment.
Merge snafu, Will fix
knative-prow-robot
added
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The following is the coverage report on pkg/.
|
We need target utilization on annation so that operators are able to set
the value per-revision in line with other PA knobs
/assign @markusthoemmes @mattmoor
/lint
Fixes #4450