Update Runtime Contract with links to Runtime tests #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add links to the associated tests for tested statements in the runtime contract. To avoid frequently changing this the link points to the test file itself instead of the exact line or function within the test. This should make it easier to visually see tested statements as well as quickly look up how a particular statement is being tested.
knative-prow-robot
added
the
size/M
|
/test pull-knative-serving-smoke-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgerd, evankanderson, markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add links to the associated tests for tested statements in the runtime
contract. To avoid frequently changing this the link points to the test
file itself instead of the exact line or function within the test.
This should make it easier to visually see tested statements as well as
quickly look up how a particular statmenet is being tested.
Release Note