Allow HTTP->HTTPS redirection on Istio Gateway #1912
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #1482.
One of the ServerTLSSettings on Istio Gatway is
httpsRedirect
that, according to docs, redirects HTTP traffic to HTTPS. Usually this is a desired behaviour for production setup, the only alternative would be to not create HTTP listener at all.PR leverages combination of
nullable
property andoneOf
withrequired
fields - this works fine currently as there is 2 distinct options (mode: <>
, which requirescredentialName
to be set, orhttpsRedirect
, which is mutually exclusive with every other option), but it might become cumbersome if more options of different combinations are added.Tested with the following specs:
and
Both produce correct Gateways.
Kubernetes 1.30 (EKS), Knative Operator 1.15.4, Knative Serving 1.15.0, Istio 1.23.0.
Proposed Changes
Release Note