Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.14] Keep the letter v at the beginning of the version number for helm chart #1802

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #1797

@knative-prow-robot knative-prow-robot force-pushed the cherry-pick-1797-to-release-1.14 branch from afb9d7e to 1c96166 Compare May 21, 2024 01:37
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 21, 2024
@knative-prow knative-prow bot requested review from houshengbo and maximilien May 21, 2024 01:37
@houshengbo
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
Copy link

knative-prow bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-1.14@bf68d68). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.14    #1802   +/-   ##
===============================================
  Coverage                ?   66.21%           
===============================================
  Files                   ?       53           
  Lines                   ?     2081           
  Branches                ?        0           
===============================================
  Hits                    ?     1378           
  Misses                  ?      588           
  Partials                ?      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit 2f7518e into knative:release-1.14 May 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants