Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release-0.15] Update the manifestival to resolve non-default ns issue #176

Merged
merged 1 commit into from
Jul 6, 2020
Merged

[Release-0.15] Update the manifestival to resolve non-default ns issue #176

merged 1 commit into from
Jul 6, 2020

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Jul 6, 2020 •
edited
Loading

Fixes #

Proposed Changes

  • This PR fixed the issue of non-default ns failure with convention webhook.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 6, 2020
knative-prow-robot
knative-prow-robot reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houshengbo: 0 warnings.

In response to this:

Fixes #

Proposed Changes

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 6, 2020
@houshengbo houshengbo changed the title Update the manifestival to resolve non-default ns issue [Release-0.15] Update the manifestival to resolve non-default ns issue Jul 6, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/install.go 70.0% 64.7% -5.3

@houshengbo houshengbo merged commit d1c0186 into knative:release-0.15 Jul 6, 2020
jcrossley3 added a commit to openshift-knative/operator that referenced this pull request Jul 21, 2020
@jcrossley3
Upstream 0.15.2 (#23)
169bfdf 
* Add 0.15.2 of serving and eventing manifests (knative#173) (knative#174)

* Update the manifestival to resolve non-default ns issue (knative#176)

* Remove istio from 0.15.2 and avoid Job naming conflict

Co-authored-by: Vincent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@matzew matzew Awaiting requested review from matzew

@trshafer trshafer Awaiting requested review from trshafer

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@houshengbo @knative-prow-robot @knative-metrics-robot @googlebot