Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Update the manifest to the nightly built version #187

Closed
wants to merge 1 commit into from

Conversation

houshengbo
Copy link

Issue to be fixed

Fixes #

Proposed Changes

Release Note

Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houshengbo: 0 warnings.

In response to this:

Issue to be fixed

Fixes #

Proposed Changes

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aliok
Copy link
Member

aliok commented Apr 10, 2020

@houshengbo
I am going to have to do the same for my PR: #186
as it depends on some config map available in the manifest.

If the file I merge is later than the one in this PR, let's close this PR.
Depends on when my PR or this PR is merged.

@aliok
Copy link
Member

aliok commented Apr 10, 2020

#186 is ready, I needed to update the manifest part of that.
The manifest in there is later than in this PR. So, I suggest we close this PR.

@Cynocracy
Copy link
Contributor

Vincent, what do you think? Should we close this?

@houshengbo houshengbo closed this Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants