-
Notifications
You must be signed in to change notification settings - Fork 46
add seccompProfile to controller and webhook #584
add seccompProfile to controller and webhook #584
Conversation
* believe this [PR](knative/serving#13327) adds the seccompProfile part to the third_party resources in serving, but I think we should do it in this repo too
@KauzClay: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #584 +/- ##
=======================================
Coverage 89.68% 89.68%
=======================================
Files 5 5
Lines 378 378
=======================================
Hits 339 339
Misses 27 27
Partials 12 12 |
yeah it should be good to add back now that we're using K8s v1.25 - google also fixed it when GKE clusters are sandboxed with gvisor /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, KauzClay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.11 |
@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dprotaso: new pull request created: #585 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
/kind
Fixes #
Release Note
Docs