Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

add seccompProfile to controller and webhook #584

Merged

Conversation

KauzClay
Copy link
Contributor

@KauzClay KauzClay commented Sep 12, 2023

Changes

  • 🧹
  • I believe this PR adds the seccompProfile part to the third_party resources in serving, but I think we should do it in this repo too

/kind

Fixes #

Release Note

Controllers and webhooks now have seccompProfile.type set to RuntimeDefault

Docs

N/A

*  believe this [PR](knative/serving#13327) adds the seccompProfile part to the third_party resources in serving, but I think we should do it in this repo too
@knative-prow
Copy link

knative-prow bot commented Sep 12, 2023

@KauzClay: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🧹
  • I believe this PR adds the seccompProfile part to the third_party resources in serving, but I think we should do it in this repo too

/kind

Fixes #

Release Note

N/A

Docs

N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 12, 2023
@knative-prow knative-prow bot requested review from ReToCode and skonto September 12, 2023 21:46
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #584 (48995a6) into main (c4ef815) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #584   +/-   ##
=======================================
  Coverage   89.68%   89.68%           
=======================================
  Files           5        5           
  Lines         378      378           
=======================================
  Hits          339      339           
  Misses         27       27           
  Partials       12       12           

@ReToCode
Copy link
Member

ReToCode commented Sep 13, 2023

Hm, there was some discussion around it here. What was the latest take on this? Should be fine, as we now have k8s min version on 1.25, right?

/cc @skonto @dprotaso

@dprotaso
Copy link
Contributor

yeah it should be good to add back now that we're using K8s v1.25 - google also fixed it when GKE clusters are sandboxed with gvisor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, KauzClay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@dprotaso
Copy link
Contributor

/cherry-pick release-1.11

@knative-prow-robot
Copy link

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link

@dprotaso: new pull request created: #585

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants