-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use http scheme instead of zim in our internal links. #917
Comments
@mgautierfr We have custom protocol handler on Android. We should keep it here, bit implement it in a way it works. I strongly oppose to launch a http daemon. |
I don't want to launch a http daemon. I want to change the scheme of the url from |
AFAIK nothing expects here the |
In #915, I understand that |
@mgautierfr After reading this I was somehow under the impression, the problem has been fixed recently. Reading #915 seems to confirm this as well. If this is confirmed, this ticket is not the way to follow. We should be able to fix #487 simply after kiwix/kiwix-build#594 is implemented, using a custom protocol. |
Considering that both#487 and 915 have been closed, this issue has lost its justification |
kiwix-desktop use a specific scheme
zim://
in the webview to reference content provided by oururlschemhandler
. This allow a well defined separation between http content which link to actual online content (which should be catch/blocked/opened with web browser) and our internal content which need a url.However, few features (as service worker #487 or Phet zim file #915) need a
http://
scheme.We should rethink how we build our internal urls and use http scheme all the time. (Use a specific host to reference internal content ?)
The text was updated successfully, but these errors were encountered: