-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hardware acceleration codecs to ffmpeg recipe #3092
Add hardware acceleration codecs to ffmpeg recipe #3092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the title is misleading, it says bump recipes version, but all I see are the hardware acceleration codecs enabled right? I imagine the bump was reverted in subsequent commits.
Having the PR rebased & squashed would be a real plus, otherwise no worry I can try to think about it at merge time.
@AndreMiras I think the original work was to bump the recipe versions, and also to add these codecs. It seems that develop received these updated versions, and this PR left behind only the hardware codecs. @DexerBR do you agree with this assessment? I updated the title to match the new reality. |
I agree, the versions have been updated in this PR: #3065 @brentpicasso How about updating the title to "Add hardware acceleration codecs to |
@DexerBR done! |
No description provided.