Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardware acceleration codecs to ffmpeg recipe #3092

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

brentpicasso
Copy link
Contributor

No description provided.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the title is misleading, it says bump recipes version, but all I see are the hardware acceleration codecs enabled right? I imagine the bump was reverted in subsequent commits.
Having the PR rebased & squashed would be a real plus, otherwise no worry I can try to think about it at merge time.
image

@brentpicasso brentpicasso changed the title Bump recipes version av Add hardware acceleration codecs Dec 13, 2024
@brentpicasso
Copy link
Contributor Author

@AndreMiras I think the original work was to bump the recipe versions, and also to add these codecs.

It seems that develop received these updated versions, and this PR left behind only the hardware codecs. @DexerBR do you agree with this assessment?

I updated the title to match the new reality.

@DexerBR
Copy link
Contributor

DexerBR commented Dec 13, 2024

@AndreMiras I think the original work was to bump the recipe versions, and also to add these codecs.

It seems that develop received these updated versions, and this PR left behind only the hardware codecs. @DexerBR do you agree with this assessment?

I updated the title to match the new reality.

I agree, the versions have been updated in this PR: #3065

@brentpicasso How about updating the title to "Add hardware acceleration codecs to ffmpeg recipe"?

@brentpicasso brentpicasso changed the title Add hardware acceleration codecs Add hardware acceleration codecs to ffmpeg recipe Dec 13, 2024
@brentpicasso
Copy link
Contributor Author

@brentpicasso How about updating the title to "Add hardware acceleration codecs to ffmpeg recipe"?

@DexerBR done!

@AndreMiras AndreMiras merged commit 37d272c into kivy:develop Dec 13, 2024
33 checks passed
@brentpicasso brentpicasso deleted the bump_recipes_version_av branch December 13, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants