Custom datetime converter #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismostert
force-pushed
the
custom_datetime_converter
branch
from
ce90aa9 to
934e324
Compare
praseodym
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Nice work!
You could consider speeding up the tests by running them in parallel with e.g. pytest-xdist.
praseodym
reviewed
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a custom XmlDateTime converter to fix the fractional_seconds being left out when they are exactly 0.
See #3 and tefra/xsdata#917
Additionally, added a Github action so that tests on EML files are ran automatically without having to include the data in this repository. Zip files specified in
testfiles.txtare downloaded and unzipped by the Github action, after which pytest can run.