Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fhl dev #133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fhl dev #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a448ea6
change cmake command
hailingfang Jun 22, 2022
850bfab
bamtools library directory may named lib64
hailingfang Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMake/FindBamTools.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# BAMTOOLS_FOUND - true if BAM has been found and can be used

find_path(BAMTOOLS_INCLUDE_DIR api/BamReader.h PATHS ${BAMTOOLS_ROOT}/include PATH_SUFFIXES bamtools ../include ../include/bamtools)
find_library(BAMTOOLS_LIBRARY bamtools PATHS ${BAMTOOLS_ROOT}/lib PATH_SUFFIXES bamtools ../lib)
find_library(BAMTOOLS_LIBRARY bamtools PATHS ${BAMTOOLS_ROOT}/lib64 ${BAMTOOLS_ROOT}/lib PATH_SUFFIXES bamtools ../lib)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjaminfang The default is /lib64? We could check whether this exists in the Dockerfile + Docker image...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. On my system, CentOS8, it is.


include(FindPackageHandleStandardArgs)
FIND_PACKAGE_HANDLE_STANDARD_ARGS(BAMTOOLS
Expand Down
2 changes: 1 addition & 1 deletion docs/setup.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Build (**replace "/installation/path" with path to the folder, where you want to

mkdir dropEst/build
cd dropEst/build
cmake -D CMAKE_INSTALL_PREFIX="/installation/path" . && make
cmake -DCMAKE_INSTALL_PREFIX="/installation/path" .. && make

Install:

Expand Down