refactor(member): 활동 페이지, 지원 페이지 오류 수정 #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fccb059 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gwansikk
requested changes
Oct 7, 2024
apps/member/package.json
Outdated
| @@ -23,6 +23,7 @@ | |||
| "@tanstack/react-query-devtools": "^5.40.1", | |||
| "dayjs": "^1.11.10", | |||
| "framer-motion": "^10.18.0", | |||
| "html-entities": "^2.5.2", | |||
There was a problem hiding this comment.
HTML Entity를 처리하는 유틸이 기존에 있어요. 패키지를 설치한 이유가 있을까요?
There was a problem hiding this comment.
앗 utils에 있는 걸 놓쳤네요. toDecodeHTMLEntities 유틸로 변경하겠습니다 알려주셔서 감사해요 :)
| @@ -37,9 +37,11 @@ const AssignmentListSection = ({ dueDate }: AssignmentListSectionProps) => { | |||
| } | |||
| const { data: assignmentList } = useActivityGroupBoardByParent({ | |||
| parentId: +assignmentId, | |||
| size: 99, | |||
There was a problem hiding this comment.
해당 API를 사용할때 필요한 크기라면 훅 기본값으로 설정해두는게 좋을거 같아요
|
빌드 에러도 확인해주세요 |
gwansikk
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
활동 페이지와 지원 페이지 내부에 있는 오류들을 수정합니다.
Tasks
size기본 값으로 모든 인원이 나타나지 않았던 문제 보완queryKey수정하여 페이지네이션이 정상적으로 작동하도록 수정selectRecruitment의 초기값을length의id로 변경하여id값이 달라서 나타나지 않았던 문제 해결To Reviewer
Approve 된 후 프로덕션에 배포 예정입니다.