Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse gitlab pipeline status to their GitHub equivalent #4

Closed
wants to merge 5 commits into from

Conversation

ashearin
Copy link
Collaborator

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)


@ashearin ashearin force-pushed the gitlab-conclusion-fields branch from eb3f853 to 39f5ea3 Compare November 29, 2023 23:05
@ashearin ashearin force-pushed the gitlab-conclusion-fields branch from c849068 to c28bf22 Compare November 30, 2023 00:01
@ashearin ashearin force-pushed the gitlab-conclusion-fields branch from c28bf22 to eb6ffe5 Compare November 30, 2023 00:19
@ashearin ashearin temporarily deployed to integration-test December 1, 2023 00:59 — with GitHub Actions Inactive
@ashearin ashearin temporarily deployed to integration-test December 4, 2023 16:00 — with GitHub Actions Inactive
ashearin and others added 4 commits December 4, 2023 09:01
* Trust pinned GitHub download URLs

 Trust files that are downloaded from `raw.githubusercontent.com` where the file's ref is a Git SHA and therefore immutable.
Resolves ossf#3339.
Signed-off-by: martincostello <[email protected]>

* Move logic to function

- Add `hasUnpinnedURLs` function.
- Add test cases for different URLs.
Signed-off-by: martincostello <[email protected]>

* Fix formatting

Appease the linter.
Signed-off-by: martincostello <[email protected]>

* Suppress lint warnings

Suppress warning on three long URLs.
Signed-off-by: martincostello <[email protected]>

* Address peer review

Address peer review feedback.
Signed-off-by: martincostello <[email protected]>

* Fix lint warning

Fix lint warning.
Signed-off-by: martincostello <[email protected]>
Signed-off-by: Allen Shearin <[email protected]>
Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.16.1 to 0.17.0.
- [Release notes](https://github.com/google/go-containerregistry/releases)
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml)
- [Commits](google/go-containerregistry@v0.16.1...v0.17.0)

---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Allen Shearin <[email protected]>
@ashearin ashearin closed this Dec 6, 2023
@ashearin ashearin deleted the gitlab-conclusion-fields branch December 11, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants