Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(common/web): remove .c8rc.json from types and merge exclusions into package.json #12813

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore(common/web): remove .c8rc.json from types and merge exclusions into package.json #12813

wants to merge 3 commits into from
+8 −14

Conversation

markcsinclair
Copy link
Contributor

@markcsinclair markcsinclair commented Dec 9, 2024 •
edited
Loading

Running ./build.sh test on common/web/types currently includes test files as well as source. Removing .c8rc.json and merging the exclusions from there into package.json fixes this.

(Fix suggested by @mcdurdin)

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 9, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S17 milestone Dec 9, 2024
@markcsinclair markcsinclair marked this pull request as draft December 9, 2024 14:50
@markcsinclair markcsinclair self-assigned this Dec 9, 2024
@markcsinclair markcsinclair added web/ and removed web/ labels Dec 9, 2024
@markcsinclair markcsinclair marked this pull request as ready for review December 9, 2024 14:53
ermshiperete
ermshiperete requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is a comment in common/web/types/build.sh that references .c8rc.json that should be removed now.

@github-actions github-actions bot added web/ and removed web/ labels Dec 10, 2024
@markcsinclair
Copy link
Contributor Author

LGTM, but there is a comment in common/web/types/build.sh that references .c8rc.json that should be removed now.

Done

ermshiperete
ermshiperete approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now really LGTM 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermshiperete ermshiperete ermshiperete approved these changes

@jahorton jahorton Awaiting requested review from jahorton jahorton is a code owner

@mcdurdin mcdurdin Awaiting requested review from mcdurdin mcdurdin is a code owner

Assignees

@markcsinclair markcsinclair

Labels
chore common/web/ common/ web/
Projects
Keyman
Status: No status
Milestone
A18S17
Development

Successfully merging this pull request may close these issues.
2 participants
@markcsinclair @ermshiperete