Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render dynamic data inside glider-track #131

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Conversation

kevinfarrugia
Copy link
Owner

children are placed inside a div if skipTrack is falsy. This resolves the following exception in React when cleaning up dynamic data since the key prop would not match what is in the DOM and the slides would not be updated until re-mounted.

Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

Closes #121

@vercel
Copy link

vercel bot commented Oct 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-glider ✅ Ready (Inspect) Visit Preview Oct 7, 2022 at 8:16AM (UTC)

@kevinfarrugia kevinfarrugia merged commit b914c89 into master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught DOMException: Failed to execute 'removeChild' on 'Node'
1 participant