Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More metatadata in the JSON response #81

Closed
kermitt2 opened this issue Jun 18, 2018 · 4 comments
Closed

More metatadata in the JSON response #81

kermitt2 opened this issue Jun 18, 2018 · 4 comments
Assignees
Milestone

Comments

@kermitt2
Copy link
Owner

Add in the JSON response a bit more metadata consistent with other tools:

{ 
...
  "software": "entity-fishing",
  "version": "0.0.4",
   "date": "2018-05-02T12:24:55.529301",
...
}
(date is the date of generation of the response)
@tantikristanti
Copy link
Collaborator

tantikristanti commented Oct 18, 2018

Hello @kermitt2 ,

I implemented methods regarding this issue in a branch metadataJSON. Below is the result, what do you think?

screen shot 2018-10-18 at 17 54 02

@lfoppiano
Copy link
Collaborator

I add here, as mentioned in f30ea39#commitcomment-30958982, we should add also an entry point in the API /version returning the version number (and the name, since we have also the name)

@tantikristanti
Copy link
Collaborator

An entry point /version in the API returning the name, the version number and the description has been added in the same branch metadataJSON.

screen shot 2018-10-19 at 13 40 54

@lfoppiano lfoppiano assigned tantikristanti and kermitt2 and unassigned kermitt2 Oct 19, 2018
@tantikristanti
Copy link
Collaborator

Thanks for the input @lfoppiano . All the fixes has been done in the same branches. I will make the pull request if everything is OK.

lfoppiano pushed a commit that referenced this issue Nov 15, 2018
* Add application metadata information in the JSON response #81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants