Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parts of translation files #2494

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

birkskyum
Copy link
Collaborator

@birkskyum birkskyum commented Dec 21, 2023

Adding a style previously requested an api key, but these fields are now commented out because a potential style api key are a part of the style url, so the translations aren't needed either.

it also resolves some step numbering inconsistencies:

before:
Screenshot 2023-12-21 at 22 51 35

after:
Screenshot 2024-03-12 at 19 17 28

@birkskyum birkskyum force-pushed the remove-unused-parts-of-translation-files branch from cca9540 to 726213b Compare December 21, 2023 21:50
@ibgreen ibgreen requested a review from heshan0131 December 22, 2023 17:17
@ibgreen ibgreen requested a review from macrigiuseppe January 27, 2024 12:59
@birkskyum birkskyum force-pushed the remove-unused-parts-of-translation-files branch 2 times, most recently from 3f32127 to e493795 Compare March 12, 2024 18:07
@birkskyum
Copy link
Collaborator Author

birkskyum commented Mar 12, 2024

@ibgreen , there is a bit of confusion about how to add custom styles. This clarified the translations and is a cleanup step.

There has for a long time (since before i started looking into kepler.gl) been a bug related to a disabled "add style" button that I'd like to debug when this is in.

@ibgreen ibgreen requested a review from ilyabo March 12, 2024 18:19
@birkskyum birkskyum force-pushed the remove-unused-parts-of-translation-files branch from e493795 to c9f3283 Compare July 25, 2024 05:07
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for keplergl2 ready!

Name Link
🔨 Latest commit c9f3283
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/66a1dd771c5a480008bd9164
😎 Deploy Preview https://deploy-preview-2494--keplergl2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@birkskyum
Copy link
Collaborator Author

birkskyum commented Jul 25, 2024

@akre54 , this is a bit of a cleanup step in continuation of the fix you made recently on the style url (#2564), so I've rebased it now that the style url's work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant