This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
fix: Remove Windows => UNIX variable conversion #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, Windows-style env variables (%test%) would be converted to UNIX-style format ($test) in UNIX systems. That was an undocumented feature. I've removed that to simplify code a bit. Of course, UNIX to Windows format still works, as that's the intended use of cross-env. BREAKING CHANGE: %windows_style% env variables will no longer be converted to $unix_style in UNIX machines. To fix it, use always the UNIX syntax, cross-env will change the format in Windows machines as needed
kentcdodds
approved these changes
Mar 24, 2017
kentcdodds
pushed a commit
that referenced
this pull request
Mar 31, 2017
Before, Windows-style env variables (%test%) would be converted to UNIX-style format ($test) in UNIX systems. That was an undocumented feature. I've removed that to simplify code a bit. Of course, UNIX to Windows format still works, as that's the intended use of cross-env. BREAKING CHANGE: %windows_style% env variables will no longer be converted to $unix_style in UNIX machines. To fix it, use always the UNIX syntax, cross-env will change the format in Windows machines as needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, Windows-style env variables (
%test%) would be converted to UNIX-style format ($test) in UNIXsystems. That was an undocumented feature. I've removed that to simplify code a bit. Of course, UNIX
to Windows format still works, as that's the intended use of cross-env.
BREAKING CHANGE:
%windows_style%env variables will no longer be converted to$unix_stylein UNIXmachines. To fix it, use always the UNIX syntax, cross-env will change the format in Windows
machines as needed
As discussed in #90 (comment)