Skip to content
This repository has been archived by the owner on Jan 6, 2021. It is now read-only.

Enforce minimum Node.js version requirement using 'engines' attribute package.json #48

Merged
merged 3 commits into from
Jan 3, 2017

Conversation

compumike08
Copy link
Contributor

Since the cross-env can only support Node.js version 4.0 or greater as of cross-env version 3.0.0, I added an engines attribute to package.json which will enforce the presence of Node.js version 4.0 or greater. If someone tries to run/build cross-env with an older version of Node.js, the engines attribute will cause an error to be thrown as soon as they try to run npm install (or otherwise try to run/build the project).

In addition, I also added a Prerequisites section to README.md which states that Node.js version 4.0 or greater is required.

@codecov-io
Copy link

Current coverage is 100% (diff: 100%)

Merging #48 into master will not change coverage

@@           master   #48   diff @@
===================================
  Files           2     2          
  Lines          55    55          
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
  Hits           55    55          
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last update 25f7b5f...7f1dff9

@kentcdodds kentcdodds merged commit b4a0063 into kentcdodds:master Jan 3, 2017
@kentcdodds
Copy link
Owner

Thank you!

@compumike08
Copy link
Contributor Author

@kentcdodds: You're welcome.

@compumike08
Copy link
Contributor Author

@kentcdodds: Out of curiosity, do you have a regular release schedule for creating new releases and publishing them to the npm registry, or do you create releases as needed?

@kentcdodds
Copy link
Owner

It's automated. This has already been released! https://github.com/kentcdodds/cross-env/releases

@compumike08
Copy link
Contributor Author

@kentcdodds: Oh, cool! What do you use to automate the release process?

@kentcdodds
Copy link
Owner

See this: https://kcd.im/write-oss and/or: https://kcd.im/fem-oss

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants