Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to continue maintenance on this library? #73

Open
GregDungca opened this issue Oct 7, 2019 · 7 comments
Open

Any plans to continue maintenance on this library? #73

GregDungca opened this issue Oct 7, 2019 · 7 comments

Comments

@GregDungca
Copy link

I see that the last release on pypi was 1.4.0, which was released on April 18, 2015.
https://pypi.org/project/jsonpath-rw/#history

There seems to be a few useful features implemented or partially implemented since then. I'm mainly interested in the update() functionality partially implemented in #28.

So, should we expect maintenance and development to continue for this library?

@kennknowles
Copy link
Owner

I have no time to maintain it, but I would accept patches (preferably very easy to review). Anyone who contributes some code I would probably give write access immediately. There are some newer forks you could check out, too.

@ailjushkin
Copy link
Collaborator

ailjushkin commented Oct 13, 2019

The problem

This repo is actively used in projects around the world having 700 thousands of downloads monthly. In compairson to all its forks it is still the main python package that should be maintained. But because the author of this project is no longer want to be a maintainer, this project overgrowth with different forks which is not good, because normally those forks should be merged overhere and be released under a new version of python-jsonpath-rw.

As I understood it correctly, @kennknowles will give write access permissions to any new maintainer who will breathe new life into this repository.

Repository analytics

I've analyzed each fork of this repo.

For now we have bunch of small old individual forks with few commits and one big fork as an alternative package implementation (but it was left without support since 2017) from @h2non user.

Minor forks

They can be considered as potential PRs to this repository. Those guys have small unmerged commits but their forks are no longer developed after that.

@mloudon - on 14 Jul 2014: mloudon@cd55cf0
@zsolt-erl - on 7 Jan 2015: zsolt-erl@7a78c1e
@yougov - on 31 Mar 2015 yougov@7293c51
@cdent - on 22 May 2015 cdent@237628f
@jonathanglima - on 5 Jul 2016 jonathanglima@8f66e60
@wangjild on 10 Mar 2017 - wangjild@5dadd0b
@ejhayes on 5 Dec 2018 ejhayes@4706382
@NaasCraft committed on 28 Oct 2018 NaasCraft@bc7d43a
@kaapstorm committed on 21 Mar 2018 kaapstorm@a2ee357
@movermeyer committed on 5 Mar 2018 movermeyer@2238b6f
@nick9999 committed on 25 Oct 2017 nick9999@fd8a6c3 and nick9999@8a05f33
@tianjuan committed on 13 Jul 2017 tianjuan@7ea6599

One major fork https://github.com/h2non/jsonpath-ng

This guy has started an alternative version of python-jsonpath-rw called h2non/jsonpath-ng and this fork were in active development for some time and it even overgrown with his own forks:

@h2non last committed on 26 Nov 2017: h2non@003a0b7

Its forks are:

@guandalf committed on 10 Jul guandalf@cf25057
@dlacher1 committed on 27 Jun dlacher1@8cacb50
@rahendatri committed on 22 May https://github.com/rahendatri/jsonpath-ng/commit/03cf41844419a0565f2a9a7d52ce1dad89b43a39
@dcreemer committed on 5 Jan 2018 dcreemer@2825f82
@jksecurity committed on 11 Sep 2017 https://github.com/jksecurity/jsonpath-ng/commit/47b33d7a0e9b68a80d730d5d384308e0156b546c

What next steps should be done in order to keep this project up to date

  1. Notify each person who wants to maintain this project and give them permissions to do it - post your comments here in the thread if you are ready for that.
  2. Merge "major fork" into this project.
  3. Gradually review each fork of the project, contact the authors and decide on the merge of these changes into the main project.

@ailjushkin
Copy link
Collaborator

ailjushkin commented Oct 13, 2019

Hi guys.

If you have the time and desire to independently support this repository, please write here a message and get access rights to work with this project from @kennknowles.

Otherwise, the situation with the forks of the repository will only become worse.

The goal is to finally get one relevant code in this project, and close all its forks.

The main issue is described in my letter above:
#73 (comment)

Notifications list:

@mloudon
@zsolt-erl
@yougov
@cdent
@jonathanglima
@wangjild
@ejhayes
@NaasCraft
@kaapstorm
@movermeyer
@nick9999
@tianjuan
@h2non
@guandalf
@dlacher1
@rahendatri
@dcreemer
@jksecurity
@ulidtko

@cdent
Copy link

cdent commented Oct 14, 2019

My sorted patch was integrated into https://github.com/sileht/python-jsonpath-rw-ext (/cc @sileht ) which provides several extensions to this package. I use it, plus the code here, to drive jsonpath tests in https://github.com/cdent/gabbi where jsonpath handling is pretty much the critical feature, so I have a vested interested interested in making sure this stays alive. I'm happy to take on some maintenance responsibilities if people are required.

ulidtko added a commit to ulidtko/python-jsonpath-rw that referenced this issue Oct 22, 2019
@ulidtko
Copy link

ulidtko commented Oct 22, 2019

FWIW, passing maintainership of the repo to someone ready to reconcile the cross-fork effort fragmentation and roll out a new release, is absolutely needed.

@mrjcleaver
Copy link

Thanks for this thread. It helped me make the decision to not use the library.

@sherbang
Copy link

In case it helps others. My search for a jsonpath library ended with me using JMESPath for my use-case. I wrote a short blog post on my decision process.

kaapstorm pushed a commit to kaapstorm/python-jsonpath-rw that referenced this issue Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants