Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint issue with micropkg typing #3673

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Fix lint issue with micropkg typing #3673

merged 2 commits into from
Mar 1, 2024

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Mar 1, 2024

Description

Fix #3670 and #3669

Development notes

Inside the build package they changed the logic around importing importlib for various python versions: pypa/build#692

This has messed with the type checking in our micropkg code. I couldn't get the type checking to work for all python versions after this change, so I ignored it.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@merelcht merelcht self-assigned this Mar 1, 2024
@merelcht merelcht linked an issue Mar 1, 2024 that may be closed by this pull request
@merelcht merelcht marked this pull request as ready for review March 1, 2024 12:23
@merelcht merelcht merged commit 1bbfdea into main Mar 1, 2024
28 checks passed
@merelcht merelcht deleted the fix-lint-job branch March 1, 2024 13:10
merelcht added a commit that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Nightly build failure on develop ci: Nightly build failure on main
3 participants